Found possible bug

[david.dda]

ok, I am trying to compile the 9_6 version. You mean I have to uninstall the FileZilla Server first? I compiled 3 versions 9_6, 9_15 and 9_32, but neither of those three could start the server. So I have to uninstall all first? You wrote: "answer the first question with no and you'll be given that option" - where do I have to answer the question? - in Visual Studio?

[botg]

Obviously the question you get when starting FileZilla Server since you didn't mention getting any other questions.

[david.dda]

I tried to uninstall the service and start again and the server logged on, so that´s fine. There is one more thing: I did three copies of the version 9_6 and compiled all of them, so I have 3 "FileZilla Server.exe" files in three separate Release folders. I did this because I modified the code a little bit and did therefore some backup for each modified version. Now, when I start the server with the "FileZilla Server.exe" file (in the first released version for 9_6) I can still stop it with the second "FileZilla Server.exe", which I did for backup, but both versions are slightly different. How do I now, which one was started? I am asking this, because I downloaded the executable files for FileZilla Server - versions 9_6, 9_15 and 9_32, installed and started the version 9_32 first, than stopped it, and started the version 9_6, but in the output window of the Server was still written that I am connected to the previous version 9_32..

[botg]

It starts the executable that last registered itself as service.

[david.dda]

so, the executable register themselves as a service when I start them? - (clicking on the "FileZilla Server.exe" file?) - so the last executable for FileZilla Server is the last executed (started) "FileZilla Server.exe" file?

[botg]

No, the one you last told to install as service.

[david.dda]

I think that´s the version included below Start-Control Panel-Administrative Tools-Services, there you´ll find the service "FileZilla Server FTP server" and by choosing Properties, there is the path to the actual version of FileZillaServer.

[boco]

For testing, simply use the /compat switch to start it as a program.

[david.dda]

Hi, what is a /compat switch? Where should I use it?

[boco]

Code: Select all

"FileZilla Server.exe" /compat /start

This starts the executed FileZilla Server.exe as a program, not as a service. Great for testing, you don't have to constantly install and uninstall services.

[david.dda]

I had a question to a possible memory leak in the AsyncSocketExLayer.cpp file. You created a pointer *pMsg with a new allocation of type t_LayerNotifyMsg, afterwords you use this pointer as a parameter in the PostMessage() function, if the PostMessage() function returns null - (!res), you deallocate the pMsg pointer, but if the PostMessage() function complete successfully, you don't deallocate the pMsg pointer. Does the PostMessage function, when executing successfully deallocate the pointer by itself, or is it then a memory leak?

Code: Select all

	t_LayerNotifyMsg *pMsg=new t_LayerNotifyMsg;
	pMsg->hSocket = m_pOwnerSocket->m_SocketData.hSocket;
	pMsg->lEvent = ( lEvent % 0xffff ) + ( nErrorCode << 16);
	pMsg->pLayer=bPassThrough?m_pPrevLayer:this;
	BOOL res=PostMessage(m_pOwnerSocket->GetHelperWindowHandle(), WM_USER,  
               (WPARAM)m_pOwnerSocket->m_SocketData.nSocketIndex, (LPARAM)pMsg);
	if (!res)
		delete pMsg;
	return res;
} //end of function

[botg]

Post Message is one of the fundamental Windows API functions.

[david.dda]

I compiled an older version of FileZilla Server 9-6, when I start the server and connect a FileZilla Client (version 3-3-1) the server disconnect the connection after 2 minutes. When I click in the GUI of the client on some folder shared by the server, the server connects automatically again, but disconnects after 2 minutes, even when I transfer some files (server is disconnected, but file-transfer is still running). Bellow you will find the output of the server (last two lines appear, when the connection closes - after 2 minutes)
...
(000009) 10/30/2009 17:10:42 PM - (not logged in) (127.0.0.1)> 220-written by Tim Kosse (Tim.Kosse@gmx.de)
(000009) 10/30/2009 17:10:42 PM - (not logged in) (127.0.0.1)> 220 Please visit http://sourceforge.net/projects/filezilla/
(000009) 10/30/2009 17:10:42 PM - (not logged in) (127.0.0.1)> USER David
(000009) 10/30/2009 17:10:42 PM - (not logged in) (127.0.0.1)> 331 Password required for david
(000009) 10/30/2009 17:10:42 PM - (not logged in) (127.0.0.1)> PASS
(000009) 10/30/2009 17:10:42 PM - david (127.0.0.1)> 230 Logged on
(000009) 10/30/2009 17:10:42 PM - david (127.0.0.1)> PWD
(000009) 10/30/2009 17:10:42 PM - david (127.0.0.1)> 257 "/" is current directory.
(000009) 10/30/2009 17:12:42 PM - david (127.0.0.1)> 421 Connection timed out.
(000009) 10/30/2009 17:12:42 PM - david (127.0.0.1)> disconnected.

Client writes:
...
Antwort: 226 Transfer OK
Status: Anzeigen des Verzeichnisinhalts abgeschlossen
Antwort: 421 Connection timed out.
Fehler: Verbindung vom Server geschlossen

Please can you answer me, if the connection timeout is caused by some bug in the code, or if it should disconnect after 2 minutes and wait for some action of clients to get connected again?

[botg]

See the server's settings dialog.

[david.dda]

Thanks a lot, I didn´t notice it. Why do you want the server to disconnect after 120 seconds? - is there any danger of overloading the FTP connection?