FileZilla 3 development diary

[thorin]

Great work!

Thorin

[Patte]

REEEEEEESPECT

[botg]

Time to submit another patch

This time it's about the wxListCtrl::OnGetItem* functions for virtual list controls. They are declared as const for no appareant reason. If I overload them, why shouln't I be allowed to modify the instance?

[pixolex]

your baby is growing fast!

[botg]

Unfortunately my wxListCtrl patch just got rejected, since it would break working code.

Instead now I have to use ugly const casts and such things, with the usual problems coming from that, like incompatibilities with compiler optimizations and such.

The holy grail of backwards compatibility seems to be more important like a clean good design.

[botg]

My whole body is shaking, I had to write a horrible line of code, so horrible that hell might freeze:

Code: Select all

CLocalListView *pThis = const_cast<CLocalListView *>(this);

I had to write 4 lines of documentation for this code, it's a shame

[Golyc]

My whole body is shaking, I had to write a horrible line of code, so horrible that hell might freeze:

Code: Select all

CLocalListView *pThis = const_cast<CLocalListView *>(this);

I had to write 4 lines of documentation for this code, it's a shame

WEll it is just more 0,01 bite ... more or less it will not drestroy FZ3...
in the future i will CAN say "BOTG is good he fixed this shame ^^"

[Ezh]

I prefer the way FlashFXP works woth local and remote directories - I can switch each of panels to the view I need at this time.

[panfr]

I prefer the way FlashFXP works woth local and remote directories - I can switch each of panels to the view I need at this time.

Preferring it over something you have not even seen yet shows quite a degree of devotion!

[Patte]

My whole body is shaking, I had to write a horrible line of code, so horrible that hell might freeze:

Code: Select all

CLocalListView *pThis = const_cast<CLocalListView *>(this);

I had to write 4 lines of documentation for this code, it's a shame

casts always suck... I had to cast a lot for my Gnutella client though...

[botg]

Casts itself aren't the problem, and in Java* they're a must have thx to lack of templates. (until recently)

It are the dreaded const casts. Imo const casts and gotos are on the same level: Avoid them is possible. If not, add massive comments.

[*] Pattes Gnutella client is written in Java

[crissi]

I definately have too much time.
After reading a complete book, several online manuals and some long discussions with other developers, I managed to create the neccessary input files for the GNU autotools.
From now on, FileZilla 3 compiles cleanly on Linux and hopefully any other system where wxWindows is available on.

Hmmm... I install new wxwidget (2.5.x) and try to compile cvs but it fails.
System: SuSE 9.0, gcc 3.3.1, wxwidget 2.5.1
Can you look for it?
Here is a compile log:

[log removed - botg]

[botg]

I've no idea what could be the reason for this problem. Have you already tried the latest CVS version of wxWidgets?
You also need to apply the following patch to wxWidgets which has not yet been accepted: http://filezilla.sourceforge.net/misc/subindent.patch

[crissi]

I've no idea what could be the reason for this problem. Have you already tried the latest CVS version of wxWidgets?
You also need to apply the following patch to wxWidgets which has not yet been accepted: http://filezilla.sourceforge.net/misc/subindent.patch

hmmm why I need so much actual version wxwidget?
Installed was 2.4.2 and i upgrade to 2.5.1. Maybe missing a #include?
I will try here on debian unstable (without cvs of wx).

[botg]

Development has been slowed, I'm currently arguing with quicksort about the item sorting in the local file list. It just doesn't sort properly.