Page 1 of 1

1.6.4 - Admin Panel Column Widths

Posted: 2023-01-18 18:44
by CrimpOn
(As Pooh would say, "Oh, Bother.")

Installed FileZilla Server 1.6.4. Very smooth. Alas, when the Admin Screen came up the first time, it did not carry over the column width settings from the previous version.
I have enjoyed so much that the previous version 'remembered' those settings every time the server was restarted.

Re: 1.6.4 - Admin Panel Column Widths

Posted: 2023-01-18 20:06
by botg
That functionality is only in the nightly if I remember correctly, it has not yet been tested.

Re: 1.6.4 - Admin Panel Column Widths

Posted: 2023-01-18 20:33
by CrimpOn
I had assumed that a fresh install was just "different" than a regular reboot.
It will be rather obvious on the second Tuesday of Feb when Microsoft updates force a restart.

The nightly builds, then, are not based on the current released version, but independent?
(At some point certain code changes are moved to the production version, and others are not?)

Re: 1.6.4 - Admin Panel Column Widths

Posted: 2023-01-18 20:41
by botg
Nightlies are development snapshots, that's about the only guarantee about them. They may contain unreleased features, unreleased features seen in previous nightlies may disappear, or they might outright be on a different branch for some time that doesn't see any activity. On top of this, they might not work at all.

Re: 1.6.4 - Admin Panel Column Widths

Posted: 2023-01-19 12:38
by oibaf
AFAICT the code is in the released binary, but the implementation has changed a bit, so old settings don't apply anymore. Sorry about that, but it was necessary to get things working properly.

Nightly builds contain code that might not be fully working, or even scraped from the next release. In this case, it was just modified to work better.

Re: 1.6.4 - Admin Panel Column Widths

Posted: 2023-01-21 22:56
by CrimpOn
AFAICT the code is in the released binary
This appears not to be the case. I closed FileZilla Administrator. Restarted and the column widths went back to default. Reset them. Stopped FileZilla server. Started FileZilla server. Started FileZilla Administrator. Column widths went back to default.

It's not a huge problem, merely annoying.

With a more nuanced understanding of "Nightly Builds", which version to run is more complicated.
a. Maybe a Nightly build will maintain column widths, but
b. Maybe there will be some random bug that is not obvious at first.

Oh, Bother.

Re: 1.6.4 - Admin Panel Column Widths

Posted: 2023-01-23 09:09
by oibaf
My bad. Just realized the code that persists columns hasn't made it to the released binaries. The nightly builds have it, though. We still have a couple quirks to solve before being able to release that functionality, but it would be helpful if you tested it and reported back any issues you had with it.

Re: 1.6.4 - Admin Panel Column Widths

Posted: 2023-01-24 19:29
by CrimpOn
Installed FileZilla Server Nightly Jan 23, 2023. When the Admin control panel is closed and then restarted, it does remember the size and location of the Admin panel, but does not remember the column widths.

Re: 1.6.4 - Admin Panel Column Widths

Posted: 2023-01-25 06:03
by oibaf
Well, that's odd. It totally does for me. Silly question, but are you sure you're running the proper binary? Does the file %LOCALAPPDATA%\filezilla-server-gui\settings.xml contain <columns> elements? If so, can you paste them here?

Re: 1.6.4 - Admin Panel Column Widths

Posted: 2023-01-25 06:45
by CrimpOn
Oh, my. "Proper binary"? I will download the most recent Nightly Build and try again. Do not see anything about "Columns" in that XML file:

Code: Select all

type settings.xml
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<filezilla xmlns:fz="https://filezilla-project.org" xmlns="https://filezilla-project.org" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" fz:product_flavour="standard" fz:product_version="1.6.5">
        <!--Information about the FileZilla FTP servers to connect to.-->
        <server>
                <name>127.0.0.1:14148</name>
                <host>127.0.0.1</host>
                <port>14148</port>
                <password></password>
                <fingerprint>72:03:af:f8:26:a5:c1:ad:a7:ba:a1:d3:41:db:1a:db:98:4b:bc:3d:ca:50:d2:43:c9:b0:3c:61:a0:17:34:06</fingerprint>
        </server>
        <autoconnect_to_server></autoconnect_to_server>
        <last_connected_server>127.0.0.1:14148</last_connected_server>
        <!--Logging options-->
        <logger>
                <!--The name of the log file. If empty, the log goes to stderr.-->
                <name></name>
                <!--The maximum number of files to be used for the log rotation. Default is 0, meaning no rotation happens.-->
                <max_amount_of_rotated_files>0</max_amount_of_rotated_files>
                <!--The maximum size each log file can reach before being closed and a new one being opened. Only meaningful if max_amount_of_rotated_files > 0.-->
                <max_file_size>4294967295</max_file_size>
                <!--Which types of logs must be enabled. Defaults to error|status|reply|command . See <libfilezilla/logger.hpp> for the values of the various types.-->
                <enabled_types>3</enabled_types>
                <!--Criteria used to rotate files. Currently: size-based (0) or daily rotation (1).-->
                <rotation_type>0</rotation_type>
                <!--Include headers for each line of logging (date&time and possibly others). Set it to false if you have your own way of tagging log lines. Default is true.-->
                <include_headers>true</include_headers>
        </logger>
        <!--The GUI's locale. By default, the one defined by the appropriate environment variables is used.-->
        <locale></locale>
        <!--True if the UI window has to be started in minimized mode, false otherwise.-->
        <start_minimized>false</start_minimized>
        <!--Tray icon mode: one of 0 (disabled), 1 (enabled), 2 (enabled, minimize to tray).-->
        <tray_icon_mode>1</tray_icon_mode>
        <!--True if the mount table editor has to warn about being cautious when setting up native paths.-->
        <native_path_warn>true</native_path_warn>
        <!--Working directory-->
        <working_dir></working_dir>
        <!--Position and sizes of the app windows. The geometry spec is as follows: [display_id:][width{xX}height][{+-}xoff{+-}yoff]. Display_id and xy offsets only apply to top windows.-->
        <geometry name="MainFrame" maximized="false">1070x408+817+74</geometry>
</filezilla>

Re: 1.6.4 - Admin Panel Column Widths

Posted: 2023-01-25 08:12
by oibaf
Sorry, turns out the recent night builds aren't produced from the master branch. Wasn't aware of that.

Will let you know when that changes.

Re: 1.6.4 - Admin Panel Column Widths

Posted: 2023-01-25 13:14
by oibaf
So, next nightly build will be produced from the development branch, hence you will have the feature back. :)

Re: 1.6.4 - Admin Panel Column Widths

Posted: 2023-01-25 16:00
by CrimpOn
Thanks for checking. Will test it tomorrow.

Re: 1.6.4 - Admin Panel Column Widths

Posted: 2023-01-26 20:46
by CrimpOn
Nightly build does remember both size/location of Admin control panel and the width of each column. Thanks!

(I have been wondering how a user would identify the specific Nightly Build that is in use. Perhaps, for example, to report an issue or comment. The install file name does not change from one night to another. Do not see anything in User\name\AppData\Local\filezillaserver-gui\settings.xml. Obviously the Admin interface knows that a Nightly Build is being run, but which one?)

Re: 1.6.4 - Admin Panel Column Widths

Posted: 2023-01-27 08:44
by botg
There is a way on the Windows and macOS builds to figure it out if you look at the digital signature of the executables, they do contain a timestamp signed by a timestamping service.